Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document eth_sign discontinuation #1319

Merged
merged 3 commits into from
May 23, 2024
Merged

Document eth_sign discontinuation #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd80a81
Document eth_sign discontinuation
alexandratran May 22, 2024
fdc296c
add mip note with placeholder
alexandratran May 22, 2024
3938669
add in mip-3 link
alexandratran May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/whats-new.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ of the [MetaMask developer page](https://metamask.io/developer/).

## May 2024

- Discontinued support for [`eth_sign`](/wallet/concepts/signing-methods/#eth_sign).
([#1319](https://github.com/MetaMask/metamask-docs/pull/1319/))
- Documented [Snaps initial connections](/snaps/reference/permissions/#initial-connections).
([#1318](https://github.com/MetaMask/metamask-docs/pull/1318/))
- Updated [Snaps allowlisting guide](/snaps/how-to/get-allowlisted) with open permissions.
Expand Down
19 changes: 11 additions & 8 deletions wallet/concepts/signing-methods.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,17 @@ Use `eth_signTypedData_v4` or `personal_sign`.

### `eth_sign`

`eth_sign` allows signing an arbitrary hash, which means it can be used to sign transactions, or any other
data. Using `eth_sign` is a dangerous phishing risk.

MetaMask disables `eth_sign` by default and does not recommend using `eth_sign` in production.
Some applications (usually internal administrator panels) use `eth_sign` for ease of
use, or due to an inability to change the associated dapp.
If a wallet user must interact with a dapp that uses `eth_sign` and accepts the risks,
the wallet user can re-enable `eth_sign` through advanced settings.
`eth_sign` allows signing an arbitrary hash, which means an attacker can use it to request users to
sign transactions or any other data.
Using `eth_sign` is a dangerous phishing risk.

To enhance user security, MetaMask no longer supports using `eth_sign`.
Use [`eth_signTypedData_v4`](#eth_signtypeddata_v4) or [`personal_sign`](#personal_sign) instead.

:::note
See [MIP-3](https://github.com/MetaMask/metamask-improvement-proposals/blob/main/MIPs/mip-3.md) for
more information about the discontinuation of `eth_sign`.
:::

### `eth_signTypedData_v1` and `eth_signTypedData_v3`

Expand Down
Loading