Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fix for 2689 to use attached properties #2762

Merged
merged 4 commits into from
Jul 8, 2022

Commits on Jul 5, 2022

  1. Refactor fix for 2689 to use attached properties

    Added attached properties for UniformCornerRadius and Style. These properties are inherited and can thus be used to manipulate a Card located inside of another UIElement (eg. the Flipper).
    nicolaihenriksen committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    cbba462 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Make CardAssist.CardStyle lenient towards unaccepted style

    Fallback to default(Style) if the TargetType is not Card.
    nicolaihenriksen committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    e375736 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Renamed CardAssist and improved guard in CardStyle setter (of attache…

    …d property)
    
    You mentioned on stream that fact that derived types would not work for the CardStyle because of the guard which is completely correct. So I loosened up the requirements by using IsAssignableFrom() instead.
    nicolaihenriksen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    4c1f8e4 View commit details
    Browse the repository at this point in the history
  2. Fixed broken Flipper (UI) tests

    Rename operation did not pick up the string literal in these tests
    nicolaihenriksen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    dacd12a View commit details
    Browse the repository at this point in the history