Refactor fix for 2689 to use attached properties #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added attached properties for UniformCornerRadius and Style. These properties are inherited and can thus be used to manipulate a Card located inside of another UIElement (eg. the Flipper).
Fallback to default(Style) if the TargetType is not Card.
Keboo
requested changes
Jul 8, 2022
| @@ -0,0 +1,34 @@ | |||
| namespace MaterialDesignThemes.Wpf; | |||
|
|
|||
| public static class CardAssist | |||
There was a problem hiding this comment.
I would rename this to FlipperAssist since the consumption is designed for flippers not cards, even though the target of the property is a card.
There was a problem hiding this comment.
I agree, I'll rename it.
Keboo
added
enhancement
release notes
Keboo
added
the
visual breaking change
…d property) You mentioned on stream that fact that derived types would not work for the CardStyle because of the guard which is completely correct. So I loosened up the requirements by using IsAssignableFrom() instead.
Rename operation did not pick up the string literal in these tests
Keboo
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of previous fix for #2689
Added attached properties for UniformCornerRadius and Style. These properties are inherited and can thus be used to manipulate a Card located inside of another UIElement (eg. the Flipper). I decided to put them in a CardAssist file to align with the other attached properties in the toolkit. It could be moved to the Card type if that is more desirable.
Added more unit- and UI tests for this as well. Also fixed a bug in the original elevated card style (UniformCornerRadius binding) caught by these tests.