Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove non-ros dependency #6

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

incebellipipo
Copy link
Contributor

Solves #5

It is not ready for merge yet; we can discuss the ways to handle SDK dependency before it.

@incebellipipo
Copy link
Contributor Author

What about adding

include(FetchContent)
if (NOT TARGET qualisys_cpp_sdk)
  message(STATUS "${PROJECT_NAME}: `qualisys_cpp_sdk` targets not found. Attempting to fetch contents...")
  FetchContent_Declare(
    qualisys_cpp_sdk
    GIT_REPOSITORY https://github.com/qualisys/qualisys_cpp_sdk
    GIT_TAG        master
  )
  FetchContent_MakeAvailable(qualisys_cpp_sdk)
else()
  message(STATUS "qualisys_cpp_sdk: `qualisys_cpp_sdk` targets found.")
endif()

to the cmakelists.txt ?

@incebellipipo
Copy link
Contributor Author

This works like that. Commit messages got a little messy though. If you find this approach good enough, I can clean up the commit messages and make another PR, or somehow update this one.

@fmrico
Copy link
Member

fmrico commented Apr 5, 2024

Hi @incebellipipo

LGTM, go ahead. Is the PR ready to merge?

Thanks!!

@incebellipipo
Copy link
Contributor Author

Nööö!!! 😆

There are too many weird commits in it. I will properly do it and create another pull request. I will turn this into a draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants