Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mocap_msgs to mocap4r2_msgs #4

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

incebellipipo
Copy link
Contributor

Hi all,

A similar pull request from mocap4r2_msgs to mocap_msgs was merged previously. Thus, I am not certain if this pull request is relevant. But when we try to install the package, we encounter a couple of problems. First, there is no 'main' or 'master' branch anymore for the mocap4r2_msgs package, it is 'rolling'. Second, the name is mocap4r2_msgs, not mocap_msgs. So, this pull request changes mocap_msgs to mocap4r2_msgs.

@fmrico
Copy link
Member

fmrico commented Jan 23, 2024

Hi @incebellipipo

These changes are related to our intention to create packages for different distros. The change of the name is related to this: ros/rosdistro#39475 (comment). The change of the name of the main branch to rolling emphasizes using rolling to develop new features. Following this rule, as soon as a new distro appears, we could directly branch to that distro to create the packages.

I will accept this PR, even with the test failing. The failure is related to the CI so that I will fix it.

Thanks for your PR ;)

@fmrico fmrico merged commit e76871d into MOCAP4ROS2-Project:main Jan 23, 2024
1 check failed
@fmrico
Copy link
Member

fmrico commented Jan 23, 2024

Actually, I will change the main branch to rolling soon, so stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants