Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRACO #62

Merged
merged 3 commits into from
Dec 12, 2022
Merged

CRACO #62

merged 3 commits into from
Dec 12, 2022

Conversation

LunatiqueCoder
Copy link
Owner

@LunatiqueCoder LunatiqueCoder commented Nov 12, 2022 •
edited
Loading

Implements #59

I definitely enjoyed working with the new version of CRACO because of the new TypeScript support and great documentation. However, the last setup that we had isn't working anymore, so I had to do a few changes:

  • removed Babel presets. No preset now, wondering if that's ok, or if we could use another one or find a solution for the metro-react-native-babel-preset to work but I believe react-scripts is using babel-preset-react-app behind the scenes.

@LunatiqueCoder LunatiqueCoder linked an issue Nov 13, 2022 that may be closed by this pull request
CRACO now supports Create React App 5 #59
Closed
@LunatiqueCoder
Copy link
Owner Author

Added metro-react-native-babel-preset.

@LunatiqueCoder LunatiqueCoder merged commit de0b2e3 into master Dec 12, 2022
LunatiqueCoder added a commit that referenced this pull request Dec 12, 2022
@LunatiqueCoder
Revert "CRACO (#62)"
8092ae9 
This reverts commit de0b2e3.
@LunatiqueCoder LunatiqueCoder deleted the CRACO branch January 22, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRACO now supports Create React App 5
1 participant
@LunatiqueCoder