Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRACO now supports Create React App 5 #59

Closed
LunatiqueCoder opened this issue Nov 8, 2022 · 7 comments · Fixed by #62
Closed

CRACO now supports Create React App 5 #59

LunatiqueCoder opened this issue Nov 8, 2022 · 7 comments · Fixed by #62

Comments

@LunatiqueCoder
Copy link
Owner

LunatiqueCoder commented Nov 8, 2022

CRACO now supports Create React App 5 and it has some shiny new docs: https://craco.js.org/

dilanx/craco#426 (comment)

@mikehardy
Copy link
Collaborator

Yeah - I have been waiting on that release before really digging in here, and wanted to ask you what you thought.
Back to CRACO, or stay with result of #54 / react-app-rewired ?

@LunatiqueCoder
Copy link
Owner Author

Although I really can't test the two at the moment against each other to see which one is a winner, I would definitely bet on the new CRACO maintainer, he seems very passionate and it looks like he worked very hard for this update.

@mikehardy
Copy link
Collaborator

Hmm - just checked "code frequency" and "contributors" for both, craco does seem more active.
Both had single person maintenance, it seemed to me, with react-app-rewired's maintainer currently mostly dormant and a fresh maintainer on craco
So on balance I think craco, but I'm not sure what it would take to unwind the change from #54 so please don't take that as any guess even on whether it is worth it to change back. I am just thinking out loud since you and I collaborate some that way - at the non-concrete "what's better..." level

@LunatiqueCoder
Copy link
Owner Author

I'll give it a shot, I'm pretty sure it won't take me more than 1-2 hours to make the change. I already did something with #46 as well, but I've been pretty busy at work. I hope to open a PR this weekend on both of the issues.

@LunatiqueCoder LunatiqueCoder mentioned this issue Nov 12, 2022
@LunatiqueCoder LunatiqueCoder linked a pull request Nov 13, 2022 that will close this issue
@mikehardy
Copy link
Collaborator

Exciting! :-)

@LunatiqueCoder
Copy link
Owner Author

LunatiqueCoder commented Dec 13, 2022

Unfortunately I'll reopen the issue since I still didn't manage to use the metro-react-native-babel-preset with CRACO and I had to revert the commit :/ 💔

@LunatiqueCoder
Copy link
Owner Author

LunatiqueCoder commented Jan 16, 2023

Since now we're using the cool Next.js build tools, we no longer need CRACO or react-app-rewired. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants