Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed results of rouge_score with accumulate='best' #2830

Merged
merged 15 commits into from
Nov 11, 2024

Conversation

rittik9
Copy link
Contributor

@rittik9 rittik9 commented Nov 7, 2024

What does this PR do?

Fixes #2148

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2830.org.readthedocs.build/en/2830/

@mergify mergify bot removed the has conflicts label Nov 7, 2024
@rittik9 rittik9 marked this pull request as draft November 7, 2024 20:51
@rittik9 rittik9 marked this pull request as ready for review November 8, 2024 08:40
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39%. Comparing base (ea29c89) to head (6959b79).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (ea29c89) and HEAD (6959b79). Click for more details.

HEAD has 168 uploads less than BASE
Flag BASE (ea29c89) HEAD (6959b79)
macOS 12 3
cpu 56 14
python3.12 12 3
torch2.5.0 4 1
torch2.0.1+cpu 12 3
python3.10 36 9
Windows 8 2
torch2.5.0+cpu 4 1
torch2.0.1 8 2
Linux 36 9
python3.11 4 1
torch2.4.1+cu121 8 2
torch2.2.2+cpu 4 1
torch2.3.1+cpu 4 1
python3.9 4 1
torch2.1.2+cpu 4 1
torch2.5.0+cu124 8 2
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2830     +/-   ##
========================================
- Coverage      69%     39%    -30%     
========================================
  Files         330     330             
  Lines       18795   18793      -2     
========================================
- Hits        12942    7306   -5636     
- Misses       5853   11487   +5634     

@rittik9 rittik9 marked this pull request as draft November 8, 2024 09:16
@rittik9 rittik9 marked this pull request as ready for review November 8, 2024 11:16
@rittik9 rittik9 marked this pull request as draft November 8, 2024 11:43
@rittik9 rittik9 marked this pull request as ready for review November 8, 2024 11:56
@Borda Borda changed the title Fix/rouge Fix mixed results of rouge_score with accumulate='best' Nov 8, 2024
@mergify mergify bot added the ready label Nov 8, 2024
@Borda Borda enabled auto-merge (squash) November 8, 2024 16:41
@Borda Borda merged commit 7147275 into Lightning-AI:master Nov 11, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rouge_score with accumulate='best' gives mixed results
3 participants