Changing build to possible use parser output for learningObjectives #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unjust
commented
Jan 8, 2024
unjust
commented
Jan 10, 2024
Comment on lines
+136
to
+137
| // '--repo', repository, | ||
| // '--version', version, |
There was a problem hiding this comment.
repo y version seran necesarios?
unjust
commented
Jan 10, 2024
Comment on lines
+171
to
+175
| const json = await JSON.parse(await readFile(dest)); | ||
| await writeFile( | ||
| path.join(buildDir, 'learning-objectives.json'), | ||
| JSON.stringify(json, null, 2), | ||
| ); |
There was a problem hiding this comment.
this step may be unnecessary since fd is the same (we are just reading and writing the same file)
unjust
force-pushed
the
parse_validate_oas
branch
from
5842d3d
to
9825b88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to build.mjs using curriculum-parser to generate learning-objectives.json file (if not validating)
Comparing the output json of
dist/learning-objectives.jsonto what is in the curriculum now there was [no difference]