Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new project.yml proposal #1779

Merged
merged 16 commits into from
Jun 13, 2024
Merged

new project.yml proposal #1779

merged 16 commits into from
Jun 13, 2024

Conversation

merunga
Copy link
Collaborator

@merunga merunga commented Mar 5, 2024 •
edited
Loading

Se agrega propuesta de nueva estructura para soportar:

  • variantes (aka rutas)
  • OAs opcionales
  • project tags

@merunga merunga requested a review from unjust March 5, 2024 17:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a7b7dde):

https://bootcamp-e078f--pr1779-feat-proyectyml-exte-t9ja0637.web.app

(expires Thu, 20 Jun 2024 15:46:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0deb13e7fc779a747039759592cb2a65964e47b2

@lupomontero lupomontero mentioned this pull request Mar 6, 2024
Open
@lupomontero lupomontero added the enhancement New feature or request label Mar 6, 2024
@unjust unjust changed the base branch from main to next March 6, 2024 17:58
unjust
unjust reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@unjust unjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesante. Y si marcamos algunos como variants, pensamos en generar proyectos por cada variant - osea que create-cohort-project preguntaria cual variant quiere generar si estas generando un variant? Si pensamos si, tambien tiene la implicacion que cada doc de variant debe seguir un convencion de nombre .

Por ultima hay 2 cosas de curriculum y curriculum parser que seria buena cerrar antes de eso.
Laboratoria/curriculum-parser#86
#1681

projects/05-fleet-management-api/project.yml Show resolved Hide resolved
projects/05-fleet-management-api/project.yml Outdated Show resolved Hide resolved
@unjust unjust changed the title new project.yml propsal new project.yml proposal Mar 14, 2024
mfdebian
mfdebian requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Díganme qué opinan de esta propuesta 😊

projects/05-fleet-management-api/project.yml Outdated Show resolved Hide resolved
projects/05-fleet-management-api/project.yml Outdated Show resolved Hide resolved
@unjust
Copy link
Contributor

unjust commented Apr 26, 2024 •
edited
Loading

Revisando eso de nuevo con el PR de curriculum-parser me gustaria documentemos los cambios que vamos a introducir en este nuevo proyect.yml y los fixtures.

Propiedades actual:

  • track: no cambios (web-dev, ux, data...)
  • learningObjectives: esos son los OAs basicos de proyecto, que van compartir la mayoria en cualquier version de proyecto.
    - optional: true si un OA de objetivos de root es opcional

Nuevos propiedades:

  • tags: un status de proyecto para ayudar con prioridad y display en el sitio (deprecated, hidden, featured)
  • variants: los variantes de proyecto depende en lenguaje o framework (java, node, react, react-typescript seria uno?, angular, python-flask, python-django)

Cuando un objetivo de root seria opcional y no una variante? Que seria un ejemplo?
Nota optional me imagino siempre sera true y no existia optional: false

@lupomontero lupomontero force-pushed the feat/proyectyml-extension-proposal branch from b87ed20 to 3313037 Compare May 27, 2024 15:56
@lupomontero lupomontero force-pushed the feat/proyectyml-extension-proposal branch from ad5e2c4 to 6cf1817 Compare June 11, 2024 17:13
lupomontero
lupomontero previously approved these changes Jun 11, 2024
View reviewed changes
mfdebian
mfdebian previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFGTM ⭐

@merunga merunga dismissed stale reviews from mfdebian and lupomontero via 7e983c0 June 11, 2024 20:35
@merunga
Copy link
Collaborator Author

merunga commented Jun 11, 2024

hola, actualicé los tags de los proyectos... estoy pensando q debería haber enviado un PR desde una nueva rama, perdon.

Hay un solo cambio q no se si habria q hacer ahora o no, y es pasar a guess the number a un proyecto de nivel 4 @mfdebian @unjust

merunga and others added 10 commits June 13, 2024 17:36
@merunga @lupomontero
new project.yml propsal
c21163c 
Se agrega propuesta de nueva estructura para soportar:
- variantes (aka rutas)
- OAs opcionales
- project tags
@merunga @lupomontero
Extend proyect.yml to support removing default OAs from a variant
a3cf196
@lupomontero
chore(pkg): Actualiza curriculum-parser a 6.0.0-alpha.0 y actualiza dist
b2d74c9
@lupomontero
feat(pkg): Drop support for Node 16
5d77834
@lupomontero
chore(cd): Actualiza actions/checkout y actions/setup-node a v4
67aa933
@lupomontero
chore(release): Bump to 9.0.0-alpha.1
3031a10
@mfdebian @lupomontero
chore(projects): Adds tentative tags to projects
aa8c038
@mfdebian @lupomontero
chore(release): Bumps version to 9.0.0-alpha.2 and updates dist files
77e19e4
@lupomontero
feat(scripts/create-cohort-project): Agrega soporte para variantes de…
3bb15f1 
… proyectos en script para coaches
@lupomontero
feat(projects/fleet-management-api): Agrega OA excluidos en variante …
17cb96a 
…de python
@lupomontero lupomontero force-pushed the feat/proyectyml-extension-proposal branch from c769d59 to a7b7dde Compare June 13, 2024 15:43
mfdebian
mfdebian approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lupomontero lupomontero merged commit 42aacfe into next Jun 13, 2024
8 checks passed
@lupomontero lupomontero deleted the feat/proyectyml-extension-proposal branch June 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unjust unjust unjust left review comments

@lupomontero lupomontero lupomontero approved these changes

@mfdebian mfdebian mfdebian approved these changes

Assignees

@lupomontero lupomontero

@mfdebian mfdebian

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merunga @unjust @lupomontero @mfdebian