-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup MPI calls #278
Merged
Merged
Cleanup MPI calls #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put for allReduce, moved some MPI functions from Utilities to Distributed, combined scan.hh with allReduce.hh and removed mpiUtilities
Merged
What do you guys think about using something like |
Yeah I see what you mean. That works for me. I will change it now. |
…fully this fixes it
mdavis36
requested changes
Jul 18, 2024
mdavis36
previously approved these changes
Jul 18, 2024
jmikeowen
reviewed
Jul 18, 2024
mdavis36
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the interface to the MPI functionality.
allReduce
andscan
wrappers to use theCommunicator::communicator()
by default and puts both in a single file.Distributed
source directory, having it provide the MPI wrappers even when MPI is not enabled; this prevents potential bugs from occurring when wrappers likeCommunicator
are present butCommunicator.hh
is not available.MPI_SUM
,MPI_MAX
, etc withSPHERAL_OP_SUM
,SPHERAL_OP_MAX
etcToDo :
RELEASE_NOTES.md
with notable changes.