ale3d #248
ale3d #248
Conversation
numbers as the fragment IDs. Using fragment IDs in evaluateDerivatives to turn off forces between fragments when they are moving away from each other.
This happens in FEusion/SPH when we update the smoothing lengths with the scaling factor.
|
But why wouldn't that tank our non-MPI build as well? |
|
We always include the Distributed source in our CMake system Lines 21 to 25 in 858faca I think ALE3D was skipping that package altogether when MPI was turned off. |
Removing a lot of stuff from GSPH we don't use.
…tsuji1/spheral
…e/tsuji1/spheral
@mdavis36 I think I've addressed both of these questions, let me know if I need to do anything else. |
cmake/spheral/SpheralHandleExt.cmake
Outdated
| #---------------------------------------------------------------------------------------- | ||
| # Spheral_Handle_Ext | ||
| #---------------------------------------------------------------------------------------- | ||
|
|
||
| # ------------------------------------------- | ||
| # VARIABLES THAT NEED TO BE PREVIOUSLY DEFINED | ||
| # ------------------------------------------- | ||
| # <lib_name>_DIR : REQUIRED : The installation location of the TPL | ||
| # <lib_name>_INCLUDES : OPTIONAL : Specific includes for the TPL | ||
|
|
||
| # ---------------------- | ||
| # INPUT-OUTPUT VARIABLES | ||
| # ---------------------- | ||
| # <lib_name> : REQUIRED : The name of the target TPL | ||
| # TPL_CMAKE_DIR : REQUIRED : Directory containing files for each TPL | ||
| # listing their library names | ||
|
|
||
| # ----------------------- | ||
| # OUTPUT VARIABLES TO USE - Made available implicitly after function call | ||
| # ----------------------- | ||
| # <lib_name> : Exportable target for the TPL | ||
| #---------------------------------------------------------------------------------------- | ||
|
|
||
| function(Spheral_Handle_Ext lib_name libname APPLE) | ||
|
|
||
| if(APPLE) | ||
| set(SHARED_EXT "dylib") | ||
| set(${lib_name}_libs ${libname}.${SHARED_EXT}) | ||
| endif() | ||
|
|
||
| endfunction() |
There was a problem hiding this comment.
The documentation here doesn't match up with what this function is doing. This also seems to completely overwrites ${lib_name}_libs to contain only a single library in the final list. I think a function that searches ${lib_name}_libs for a set of libraries to be converted that finds and replaces them as necessary would be much more usefull.
There was a problem hiding this comment.
I've rewritten this function to replace .dylib or .so extensions with .a if ENABLE_STATIC_TPL=On, and have updated the documentation.
…ABLE_STATIC_TPL. Even with ENABLE_STATIC_TPL=OFF, the default build sets polytope and silo extensions to .a, so we set it to .dylib on MacOSX here.
Summary