Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api naming #236

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Api naming #236

merged 7 commits into from
Nov 22, 2024

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Nov 21, 2024

Subsystem
All

Problem Description
Kotlin Style Guide requires us to have maximum of two consecutive cap letters in API namings in a row. We had more, like RPC and KRPC

Solution
Update naming according to style guide

@Mr3zee Mr3zee added bug Something isn't working deprecation Contains derecations labels Nov 21, 2024
@Mr3zee Mr3zee self-assigned this Nov 21, 2024
@Mr3zee Mr3zee added this to the 0.5.0 milestone Nov 21, 2024
@Mr3zee Mr3zee linked an issue Nov 21, 2024 that may be closed by this pull request
@Mr3zee Mr3zee requested a review from e5l November 21, 2024 21:53
@Mr3zee Mr3zee marked this pull request as ready for review November 21, 2024 21:57
@Mr3zee Mr3zee merged commit a21a5cc into main Nov 22, 2024
12 checks passed
@Mr3zee Mr3zee deleted the api-naming branch November 22, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecation Contains derecations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming convention
2 participants