-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming convention #88
Comments
Hey! Thank you for this issue and kind words! We should indeed take a better look at how we follow conventions in our namings, as we, for example, have even larger caps namings like Anyway, thanks for bringing that up. We will conduct internal design sessions where we will revisit all public APIs for this and other matters, so no need for a PR from your side. Can not promise, how long it could take, so hope it is not critical right now |
No problem, this is absolutely not critical. Thank you for taking a look at this! 🙏 |
Here's a similar PR from kotlinx.serialization for reference: Basically keeping it all caps when referencing the concept in docs, and changing the name in code (including the And here's some (or all?) of the RPC declarations here for anyone curious |
Hello. First of all, thanks for the awesome work on this!
I wanted to bring up a minor issue regarding the naming convention used for the library classes. The official Kotlin coding conventions guide specifies the following:
(https://kotlinlang.org/docs/coding-conventions.html#choose-good-names)
Overall, the library is using capitalized
RPC
everywhere. I think for theRPC
declaration it's ok, butRPCClient
,RPCServer
, for example, should actually beRpcClient
andRpcServer
.Again, this is minor, but it would be nice to follow the official conventions. I can open a PR with this change if you all agree.
The text was updated successfully, but these errors were encountered: