Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case of GitHub returning 204 No Content in some scenarios #1135

Merged
merged 5 commits into from
Mar 24, 2024
Merged

Handle case of GitHub returning 204 No Content in some scenarios #1135

merged 5 commits into from
Mar 24, 2024

Commits on Mar 22, 2024

  1. Handle case of GitHub returning 204 No Content in some scenarios whic… 

    …h breaks ResultPager because no array is returned (it's an empty string) - issue ResultPager::get() can return string KnpLabs#1091
    @tomcorbett
    tomcorbett committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    8a3f154 View commit details
    Browse the repository at this point in the history

  2. fix style issue raised by continuous-integration/styleci/pr

    @tomcorbett
    tomcorbett committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4fff555 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Added unit test for case of GitHub API returning 204 empty content in… 

    … ResultPager KnpLabs#1091
    @tomcorbett
    tomcorbett committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    eaa7993 View commit details
    Browse the repository at this point in the history

  2. Updated based on feedback from continuous-integration/styleci/pr

    @tomcorbett
    tomcorbett committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    08c3d7a View commit details
    Browse the repository at this point in the history

  3. Another change requested by continuous-integration/styleci/pr (but no… 

    …t for my changed code)
    @tomcorbett
    tomcorbett committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    a3d2fb8 View commit details
    Browse the repository at this point in the history