Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case of GitHub returning 204 No Content in some scenarios #1135

Merged
merged 5 commits into from
Mar 24, 2024

Conversation

tomcorbett
Copy link
Contributor

ResultPager breaks because no array is returned (it's an empty string) - issue ResultPager::get() can return string #1091

…h breaks ResultPager because no array is returned (it's an empty string) - issue ResultPager::get() can return string KnpLabs#1091
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomcorbett thanks for the PR! Can you also add a test for this to avoid any regressions in the future? Thanks!

See: https://github.com/KnpLabs/php-github-api/blob/master/test/Github/Tests/ResultPagerTest.php

@tomcorbett
Copy link
Contributor Author

@acrobat - of course, apologies, I haven't written a unit test in probably 10 years... so I apologize if this is wrong

Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries @tomcorbett, test looks good 👌

@acrobat acrobat merged commit 61b478a into KnpLabs:master Mar 24, 2024
10 checks passed
@acrobat
Copy link
Collaborator

acrobat commented Mar 24, 2024

Thanks @tomcorbett! And congrats on your first contribution! 🎉

@tomcorbett
Copy link
Contributor Author

Awesome, thank you @acrobat !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants