Support Julia 1.11+ #113
Merged
Support Julia 1.11+ #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
commented
May 21, 2024
Comment on lines
-385
to
+395
| sandbox_args = (ctx, | ||
| pkgspec, | ||
| pkgspec.path, | ||
| joinpath(pkgspec.path, "test")) | ||
| if VERSION >= v"1.8.0" | ||
| test_project_override = test_folder_has_project_file ? | ||
| nothing : | ||
| test_project_override = if VERSION >= v"1.4" && !test_folder_has_project_file | ||
| if VERSION >= v"1.8" | ||
| gen_target_project(ctx, pkgspec, pkgspec.path::String, "test") | ||
| sandbox_args = (sandbox_args..., test_project_override) | ||
| elseif VERSION >= v"1.7.0" | ||
| test_project_override = test_folder_has_project_file ? | ||
| nothing : | ||
| elseif VERSION >= v"1.7" | ||
| gen_target_project(ctx.env, ctx.registries, pkgspec, pkgspec.path, "test") | ||
| sandbox_args = (sandbox_args..., test_project_override) | ||
| elseif VERSION >= v"1.4.0" | ||
| test_project_override = test_folder_has_project_file ? | ||
| nothing : | ||
| else | ||
| gen_target_project(ctx, pkgspec, pkgspec.path, "test") | ||
| sandbox_args = (sandbox_args..., test_project_override) | ||
| end | ||
| else | ||
| nothing | ||
| end |
There was a problem hiding this comment.
Diff is hard to read but this part is just dealing with version differences for calling gen_target_project independently from sandbox args
Can we change this? |
|
To ensure that I didn't break older versions of Julia not normally tested by the CI workflow I added commit cb7a15d to validate Julia versions 1.2 - 1.10 all pass tests. |
This was referenced May 22, 2024
|
Julia 1.2 is upset about running I think I'm going to not investigate this issue further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note at this time Julia 1.11.0-beta1 is the latest released version of Julia 1.11 which is why I used
v"1.11-"in this PR. Note that the "nightly" CI jobs are setup tocontinue-on-errorso reviewers will need to view the output of those jobs to confirm it actually passes.