Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define constant to reporttests.jl #112

Merged
merged 6 commits into from
May 22, 2024
Merged

Define constant to reporttests.jl #112

merged 6 commits into from
May 22, 2024

Conversation

omus
Copy link
Member

@omus omus commented May 21, 2024

Avoids making users use joinpath(pkgdir(TestReports), "bin", "reporttests.jl") to determine the path to the runner script.

@omus omus requested a review from oxinabox May 21, 2024 19:13
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document this.

  1. by mentioning it in the readme/docs
  2. by putting a docstring on the constant

Once that is done, then LGTM

@omus
Copy link
Member Author

omus commented May 22, 2024

I did a patch bump here as I think it was an oversight not to have a public facing reference to the reporttests.jl script if we intend for users of this package to use it.

@oxinabox
Copy link
Member

oxinabox commented May 22, 2024

I would describe this as a new feature.
Now it is much easier for a user to make use of this.
Version numbers are cheap

But I am not strongly committed to that

@omus
Copy link
Member Author

omus commented May 22, 2024

Okay. As #113 is uncovering a couple of minor things to fix I'll drop the version bump here and add it later on.

@omus omus merged commit 9e9b0a6 into master May 22, 2024
10 checks passed
@omus omus deleted the cv/script-runner-const branch May 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants