Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Logistics Event filter parameter #256

Open
aloccid-iata opened this issue Aug 7, 2024 · 1 comment
Open

Review Logistics Event filter parameter #256

aloccid-iata opened this issue Aug 7, 2024 · 1 comment
Assignees
Labels

Comments

@aloccid-iata
Copy link
Collaborator

Problem statement:

Currently, when retrieving all logistics events of a logistics object, we can apply a set of query parameters to filter the events. However, these query parameters are incomplete and follow inconsistent naming conventions.

Query parameter Description Valid values
eventType (optional) Optional parameter that can be used to filter the logistics events by event type, the values MUST be comma separated
  • FOH
  • DEP
created_after (optional) Optional parameter that can be used to filter the logistics events
  • 20190926T075830Z
created_before (optional) Optional parameter that can be used to filter the the logistics events
  • 20190926T075830Z
occurred_after (optional) Optional parameter that can be used to filter the the logistics events
  • 20190926T075830Z
occurred_before (optional) Optional parameter that can be used to filter the the logistics events
  • 20190926T075830Z

Solution:

We suggest here two main changes:

  • The usage of kebab case naming convention for all parameters
  • The introduction of skip, limit and sort parameters

The final result will be like

Query parameter Description Valid values
event-code (optional) Optional parameter that can be used to filter the logistics events by event type, the values MUST be comma separated
  • FOH
  • DEP
created-after (optional) Filters the logistics events to only include those created after the specified timestamp
  • 20190926T075830Z
created-before (optional) Filters the logistics events to only include those created before the specified timestamp
  • 20190926T075830Z
occurred-after (optional) Filters the logistics events to only include those that occurred after the specified timestamp
  • 20190926T075830Z
occurred-before (optional) Filters the logistics events to only include those that occurred before the specified timestamp
  • 20190926T075830Z
sort (optional) Specifies the sorting order of the logistics events. This parameter expects a timestamp indicating the starting point
  • ASC-creationDate
  • DESC-creationDate
  • ASC-eventDate
  • DESC-eventDate
limit (optional) Limits the number of logistics events returned. The value is an integer specifying the maximum number of results
  • 2
skip (optional) Skips a specified number of logistics events before beginning to return results. This is useful for pagination
  • 5

For the event-code, the search will be executed on the @id property of the event-code object. For this reason, it's important that the @id must contains the code and be designed as valid URI. Example: https://onerecord.iata.org/ns/coreCodeLists#StatusCode_ARR

@aloccid-iata aloccid-iata self-assigned this Aug 7, 2024
@IATA-Cargo IATA-Cargo changed the title Review Logistics Event filter parameter. Review Logistics Event filter parameter Aug 12, 2024
@IATA-Cargo IATA-Cargo moved this to In review in API Changes Aug 12, 2024
@aloccid-iata
Copy link
Collaborator Author

Approved by API working group on the 16/09/2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Approved
Development

No branches or pull requests

1 participant