Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM: Change CodeListElement from EmbeddedObject to LogisticsObject #267

Open
NiclasScheiber opened this issue Sep 16, 2024 · 3 comments
Open
Labels

Comments

@NiclasScheiber
Copy link
Contributor

In order to facilitate fixed @id for CodeListElements to make them queryable inside LogisticsEvents, I propose to make CodeListElement inherit from LogisticsObject. This allows to host codes as re-usable objects while following the new recommended URI structures.

Structure:
@id: {{baseURL}}/{{codeListName}}#{{code}}

Example:
https://data_holder.org/logistics-objects/handlingCodes#ABC

@NiclasScheiber
Copy link
Contributor Author

#256

@aloccid-iata
Copy link
Collaborator

I think is a good suggestion, we need @id to be able to search with event-code. On the contrary, logistics objects have some properties that we do not need in the codelistelement. Maybe we can instantiate them as logistics objects but we can avoid having all properties. Something to discuss in details

@lambertciata
Copy link
Collaborator

See: 3cd15b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants