-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align LogisticsEvents structure between DM and API #245
Comments
Unsure about filtering LogisticsEvents being defined in API specs and handled server-side. If the filter query is to stay in the API specs, an alternative would be to use LogisticsEvent#eventName for the filter. Defining an eventCode by using a string only breaks when two separate codelists use the same code for different things. |
Adding another thought: Changing the filter parameter from For standardized event codes in air cargo, it is intended to use the StatusCode code list of the core code lists ontology. This should cover all inter-party use cases in this domain. For use cases outside of air cargo, you can refer to the LogisticsStatus code list, for example, of UNCEFACT out of the box. For further use cases, parties may want to host their own code list vocabulary as linked data. Instancing a CodeListElement as embedded object should only be used as a fallback mechanism. Hence, resolving and looking for a |
To fix this problem I suggest:
|
See: 3cd15b8 |
In current API specifications, LogisticsEvents can be filtered by event code defined as a string.
In current DM the event code is a CodeListElement.
We need to align on the structure and API specifications to either:
A side issue (x) would be that we need to better define Code Lists in CCL Ontology by adding code, codeDescription, codeListName, etc. when feasible.
The text was updated successfully, but these errors were encountered: