Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h26forge (new formula) #175923

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

h26forge (new formula) #175923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Formula/h/h26forge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
class H26forge < Formula
desc "Tool for making syntactically valid but semantically spec-noncompliant videos"
homepage "https://github.com/h26forge/h26forge"
url "https://github.com/h26forge/h26forge/archive/refs/tags/latest-8dde7ec.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a version tag rather than latest-xxx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only tags published by the project, unfortunately. Do I need to include an artificial version number for the formula?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that means, we cannot include it into core, as there is no release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are releases, as you can see here: https://github.com/h26forge/h26forge/releases

It uses the commit as the version instead of a number.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, raised a question about release scheme.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H26Forge dev here 👋

Let me know if the new release naming scheme works for y'all: https://github.com/h26forge/h26forge/releases/tag/latest-2024-07

sha256 "c4dd98a640cace84ae4dd5df31ac0367e0ee3c95c940883a329006b23b7ad273"
license "MIT"

depends_on "rust" => :build

uses_from_macos "llvm" # for libclang

def install
system "cargo", "install", *std_cargo_args
end

test do
system bin/"h26forge", "generate", "-o", "out.h264"
end
end
Loading