h26forge (new formula) #175923
Open
h26forge (new formula) #175923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new formula
chenrui333
reviewed
Jun 29, 2024
chenrui333
reviewed
Jun 29, 2024
| class H26forge < Formula | ||
| desc "Tool for making syntactically valid but semantically spec-noncompliant videos" | ||
| homepage "https://github.com/h26forge/h26forge" | ||
| url "https://github.com/h26forge/h26forge/archive/refs/tags/latest-8dde7ec.tar.gz" |
There was a problem hiding this comment.
we need a version tag rather than latest-xxx
There was a problem hiding this comment.
These are the only tags published by the project, unfortunately. Do I need to include an artificial version number for the formula?
There was a problem hiding this comment.
that means, we cannot include it into core, as there is no release
There was a problem hiding this comment.
There are releases, as you can see here: https://github.com/h26forge/h26forge/releases
It uses the commit as the version instead of a number.
There was a problem hiding this comment.
got it, raised a question about release scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?