Use Formula#oldnames to silence deprecation notices #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't really fully safely use `Formula#oldnames`, just effectively uses what `Formula#oldname` does now. https://github.com/Homebrew/brew/blob/4bbc0af6935816c75e0057364a84fd7fa8de071b/Library/Homebrew/formula.rb#L502-L515
|
Test failure looks like a temporary failure to retrieve the latest https://formulae.brew.sh/api/cask.jws.json. |
vraravam
reviewed
Jul 8, 2023
jacobbednarz
approved these changes
Jul 9, 2023
This was referenced Jul 10, 2023
|
Thanks for workaround here @colindean and for merging @jacobbednarz! |
MikeMcQuaid
added a commit
that referenced
this pull request
Jul 18, 2023
Follow up from #1225 that handles multiple oldnames.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't really fully safely use
Formula#oldnames, justeffectively uses what
Formula#oldnamedoes now.https://github.com/Homebrew/brew/blob/4bbc0af6935816c75e0057364a84fd7fa8de071b/Library/Homebrew/formula.rb#L502-L515
Fixes #1223