Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle dump spams warning messages to console regarding a deprecated function call #1223

Closed
jschank opened this issue Jul 7, 2023 · 4 comments · Fixed by #1225
Closed

bundle dump spams warning messages to console regarding a deprecated function call #1223

jschank opened this issue Jul 7, 2023 · 4 comments · Fixed by #1225
Labels

Comments

@jschank
Copy link

jschank commented Jul 7, 2023

When running $ brew bundle dump --force I get this error message. Which suggests I report it here.

Warning: Calling Formula#oldname is deprecated! Use Formula#oldnames instead.
Please report this issue to the homebrew/bundle tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/homebrew/homebrew-bundle/lib/bundle/brew_dumper.rb:160
@jschank
Copy link
Author

jschank commented Jul 7, 2023

I am using:

  • ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin22]
  • fish, version 3.6.1
  • Mac OS
    • ProductName: macOS
    • ProductVersion: 13.4.1
    • BuildVersion: 22F82
  • Homebrew
    • Homebrew 4.0.28-7-gcb61785
    • Homebrew/homebrew-core (git revision e55f3028ac5; last commit 2023-07-07)
    • Homebrew/homebrew-cask (git revision 658d814297; last commit 2023-07-07)

@hermitmaster
Copy link

Seeing the same error, the only noteworthy difference is that I'm using zsh. This just started today.

@gh640
Copy link

gh640 commented Jul 8, 2023

I met this warning when running brew bundle. My Homebrew version is same 4.0.28-7-gcb61785.

homebrew-bundle/lib/bundle/brew_dumper.rb:160:

oldname: formula.oldname,

formula.oldname:

https://github.com/Homebrew/brew/blob/4bbc0af6935816c75e0057364a84fd7fa8de071b/Library/Homebrew/formula.rb#L500-L505

Just changing formula.oldname in brew_dumper.rb:160 to formula.oldnames.first would work but there might be a better resolution.

@colindean
Copy link
Member

I've confirmed that #1225 resolves this problem. Thank you for the report!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants