fix: Issue 1325 #1328
Merged
fix: Issue 1325 #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
sundar-mudupalli-work
changed the title
…ogleCloudPlatform/professional-services-data-validator into issue-1325-random-row-bug-fix
|
/gcbrun |
nj1973
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Random Row validation was not possible due to a CLI bug introduced in PR 1310. Basically, the command line would only accept
--use-random-rowor-rr, while the backend could only understanduse_random_rowswhich was always false because'use_random_row' != 'use_random_rows'.In order to not create a breaking change - the CLI accepts
--use-random-rowand-rrand translates them intouse_random_rows, which the backend can understand.We have tests for random rows, for multiple engines - they all bypass the CLI. We have a CLI unit test, but only for column validation. Random rows is an argument to Row validation, therefore opened issue 1327
Sundar Mudupalli