Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random row filter is not working in latest release #1325

Closed
nj1973 opened this issue Nov 11, 2024 · 0 comments · Fixed by #1328
Closed

Random row filter is not working in latest release #1325

nj1973 opened this issue Nov 11, 2024 · 0 comments · Fixed by #1328
Labels
priority: p0 Highest priority. Critical issue. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nj1973
Copy link
Contributor

nj1973 commented Nov 11, 2024

In commit 783d1b0#diff-ce217c386e702709267508ebe1bc725106c6bcba326c1ccb29951d506855ae6aR1434 the following change was made:

-    use_random_rows = getattr(args, "use_random_row", False)
-    random_row_batch_size = getattr(args, "random_row_batch_size", None)
+    use_random_rows = getattr(args, consts.CONFIG_USE_RANDOM_ROWS, False)
+    random_row_batch_size = getattr(args, consts.CONFIG_RANDOM_ROW_BATCH_SIZE, None)

Notice that "use_random_row" is not the same as the value of constant consts.CONFIG_USE_RANDOM_ROWS. The value is "use_random_rows" (with a trailing "s").

We need to either:

  1. Revert the change on that line to "use_random_row" or
  2. Change the name of the option to --use-random-rows

I'm surprised we don't have tests to cover this, but perhaps first we just fix this at the highest priority and create a new issue to add a test.

@nj1973 nj1973 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p0 Highest priority. Critical issue. Will be fixed prior to next release. labels Nov 11, 2024
@helensilva14 helensilva14 linked a pull request Nov 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p0 Highest priority. Critical issue. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants