compute: added network_id to google_compute_network

[wyardley]

Add network_id to google_compute_network.

It's an integer, not a string, and follows the expected convention for naming.

This adds a note deprecating numeric_id (to be potentially removed at some later date), which will have the same value, but as a string.

Part of terraform-provider-google#20530

See also #12351 and #12339, in particular this comment, this comment, and this discussion

Let me know if you want me to break this up into two separate release notes.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `network_id` (integer) to `google_compute_network` resource and data source

compute: deprecated `numeric_id` (string) field in `google_compute_network` resource. Use the new `network_id` (integer)  field instead 

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[wyardley]

@rileykarson FYI. I think this is what you had in mind, right?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 33 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 33 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1071
Passed tests: 997
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 36 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 36 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1073
Passed tests: 999
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[shuyama1]

Thank you!