Address code review feedback

GoogleCloudPlatform · Dec 9, 2024 · 7d51257 · 7d51257
1 parent f88bff7
commit 7d51257
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/mmv1/products/compute/Network.yaml b/mmv1/products/compute/Network.yaml
@@ -124,8 +124,8 @@ properties:
   - name: 'numericId'
     type: String
     description: |
-      (Deprecated) The unique identifier for the resource. This identifier is defined by the server.
-      Use `network_id` instead.
+      The unique identifier for the resource. This identifier is defined by the server.
+    deprecation_message: '`numeric_id` is deprecated and will be removed in a future major release. Use `network_id` instead.'
     output: true
   - name: 'autoCreateSubnetworks'
     type: Boolean

diff --git a/mmv1/third_party/terraform/services/compute/data_source_google_compute_network.go.tmpl b/mmv1/third_party/terraform/services/compute/data_source_google_compute_network.go.tmpl
@@ -33,6 +33,7 @@ func DataSourceGoogleComputeNetwork() *schema.Resource {
 			"numeric_id": {
 				Type:     schema.TypeString,
 				Computed: true,
+				Deprecated: "`numeric_id` is deprecated and will be removed in a future major release. Use `network_id` instead.",
 			},
 
 			"gateway_ipv4": {

diff --git a/mmv1/third_party/terraform/website/docs/d/compute_network.html.markdown b/mmv1/third_party/terraform/website/docs/d/compute_network.html.markdown
@@ -38,7 +38,7 @@ In addition to the arguments listed above, the following attributes are exported
 
 * `network_id` - The numeric unique identifier for the resource.
 
-* `numeric_id` - (Deprecated) The numeric unique identifier for the resource. Use `network_id` instead.
+* `numeric_id` - (Deprecated) The numeric unique identifier for the resource. `numeric_id` is deprecated and will be removed in a future major release. Use `network_id` instead.
 
 * `gateway_ipv4` - The IP address of the gateway.