Supporting gke hub feature data source

[YpNo]

Fixes : hashicorp/terraform-provider-google#20521

Supporting Data source for google_gke_hub_feature to know if a feature is enabled or not

`google_gke_hub_feature`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[YpNo]

I hope I did the job correctly.

Thanks

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 111 insertions(+))
google-beta provider: Diff ( 3 files changed, 111 insertions(+))

Errors

google provider:

• The diff processor crashed while computing breaking changes. This is usually due to the downstream provider failing to compile.
• The diff processor crashed while computing changed resource schemas.

google-beta provider:

• The diff processor crashed while computing breaking changes. This is usually due to the downstream provider failing to compile.
• The missing test detector failed to run.
• The diff processor crashed while computing changed resource schemas.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gkehub2

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccDataSourceGoogleGKEHub2Feature_basic
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[hao-nan-li]

Looks like there's some build error, could you try to build locally and see what's wrong?

[YpNo]

I gonna check as soon as possible.
Thanks for your reply

[github-actions]

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[YpNo]

Hi,
it should build. I've just got some trouble with the tests.
Like this error :

# github.com/hashicorp/terraform-provider-google/google/services/gkehub2_test [github.com/hashicorp/terraform-provider-google/google/services/gkehub2.test]
google/services/gkehub2/data_source_google_gke_hub_feature_test.go:22:17: undefined: testAccCheckGoogleGkeHubFeatureDestroyProducer

But I checked on the other ressource like google_gke_hub_membership_binding where testAccCheckGKEHub2MembershipBindingDestroyProducer is undefined as well.
If you can explain to me.

[hao-nan-li]

Hi, it should build. I've just got some trouble with the tests. Like this error :

# github.com/hashicorp/terraform-provider-google/google/services/gkehub2_test [github.com/hashicorp/terraform-provider-google/google/services/gkehub2.test]
google/services/gkehub2/data_source_google_gke_hub_feature_test.go:22:17: undefined: testAccCheckGoogleGkeHubFeatureDestroyProducer

But I checked on the other ressource like google_gke_hub_membership_binding where testAccCheckGKEHub2MembershipBindingDestroyProducer is undefined as well. If you can explain to me.

The quick solution is to find where that function is and copy/paste it in your test file. https://github.com/hashicorp/terraform-provider-google/blob/551d170ae23337092daefcb4c5a70a60121ad848/google/services/gkehub2/resource_gke_hub_membership_binding_generated_test.go#L108

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 101 insertions(+))
google-beta provider: Diff ( 3 files changed, 101 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gkehub2

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccDataSourceGoogleGkeHubFeature_basic
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[YpNo]

Hi, it should build. I've just got some trouble with the tests. Like this error :

# github.com/hashicorp/terraform-provider-google/google/services/gkehub2_test [github.com/hashicorp/terraform-provider-google/google/services/gkehub2.test]
google/services/gkehub2/data_source_google_gke_hub_feature_test.go:22:17: undefined: testAccCheckGoogleGkeHubFeatureDestroyProducer

But I checked on the other ressource like google_gke_hub_membership_binding where testAccCheckGKEHub2MembershipBindingDestroyProducer is undefined as well. If you can explain to me.

The quick solution is to find where that function is and copy/paste it in your test file. https://github.com/hashicorp/terraform-provider-google/blob/551d170ae23337092daefcb4c5a70a60121ad848/google/services/gkehub2/resource_gke_hub_membership_binding_generated_test.go#L108

Thanks but it seems that there is not generated_test file for the google_gke_hub_feature resource after the "make provider". How the generated_test file is created ?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 189 insertions(+))
google-beta provider: Diff ( 4 files changed, 189 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gkehub2

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccDataSourceGoogleGkeHubFeature_basic
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[YpNo]

• TestAccDataSourceGoogleGkeHubFeature_basic

Could I have access to the build log ?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 143 insertions(+))
google-beta provider: Diff ( 3 files changed, 143 insertions(+))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 13
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 143 insertions(+))
google-beta provider: Diff ( 3 files changed, 143 insertions(+))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 13
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 143 insertions(+))
google-beta provider: Diff ( 3 files changed, 143 insertions(+))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 13
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🟢 All tests passed!

View the build log or the debug log for each test