Skip to content

Commit

Permalink
Supporting gke hub feature data source (#12459)
Browse files Browse the repository at this point in the history
  • Loading branch information
YpNo authored Dec 17, 2024
1 parent 765f91a commit 6f342c6
Show file tree
Hide file tree
Showing 3 changed files with 139 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ var handwrittenDatasources = map[string]*schema.Resource{
"google_dns_managed_zones": dns.DataSourceDnsManagedZones(),
"google_dns_record_set": dns.DataSourceDnsRecordSet(),
"google_gke_hub_membership_binding": gkehub2.DataSourceGoogleGkeHubMembershipBinding(),
"google_gke_hub_feature": gkehub2.DataSourceGoogleGkeHubFeature(),
"google_filestore_instance": filestore.DataSourceGoogleFilestoreInstance(),
"google_iam_policy": resourcemanager.DataSourceGoogleIamPolicy(),
"google_iam_role": resourcemanager.DataSourceGoogleIamRole(),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package gkehub2

import (
"fmt"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-provider-google/google/tpgresource"
transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
)

func DataSourceGoogleGkeHubFeature() *schema.Resource {
dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(ResourceGKEHub2Feature().Schema)
tpgresource.AddRequiredFieldsToSchema(dsSchema, "location")
tpgresource.AddOptionalFieldsToSchema(dsSchema, "project")
tpgresource.AddRequiredFieldsToSchema(dsSchema, "name")

return &schema.Resource{
Read: dataSourceGoogleGkeHubFeatureRead,
Schema: dsSchema,
}
}

func dataSourceGoogleGkeHubFeatureRead(d *schema.ResourceData, meta interface{}) error {
config := meta.(*transport_tpg.Config)

id, err := tpgresource.ReplaceVars(d, config, "projects/{{project}}/locations/{{location}}/features/{{name}}")
if err != nil {
return fmt.Errorf("Error constructing id: %s", err)
}

d.SetId(id)

err = resourceGKEHub2FeatureRead(d, meta)
if err != nil {
return err
}

if err := tpgresource.SetDataSourceLabels(d); err != nil {
return err
}

if err := tpgresource.SetDataSourceAnnotations(d); err != nil {
return err
}

if d.Id() == "" {
return fmt.Errorf("%s not found", id)
}
return nil
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
package gkehub2_test

import (
"fmt"
"strings"
"testing"

"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/terraform"
"github.com/hashicorp/terraform-provider-google/google/acctest"
"github.com/hashicorp/terraform-provider-google/google/tpgresource"
transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
)

func TestAccDataSourceGoogleGkeHubFeature_basic(t *testing.T) {
t.Parallel()

context := map[string]interface{}{
"random_suffix": acctest.RandString(t, 10),
}

acctest.VcrTest(t, resource.TestCase{
PreCheck: func() { acctest.AccTestPreCheck(t) },
Providers: acctest.TestAccProviders,
CheckDestroy: testAccCheckGoogleGkeHubFeatureDestroyProducer(t),
Steps: []resource.TestStep{
{
Config: testAccDataSourceGoogleGkeHubFeature_basic(context),
Check: resource.ComposeTestCheckFunc(
acctest.CheckDataSourceStateMatchesResourceState("data.google_gke_hub_feature.example", "google_gke_hub_feature.example"),
),
},
},
})
}

func testAccDataSourceGoogleGkeHubFeature_basic(context map[string]interface{}) string {
return acctest.Nprintf(`
resource "google_gke_hub_feature" "example" {
location = "global"
name = "servicemesh"
}
data "google_gke_hub_feature" "example" {
location = google_gke_hub_feature.example.location
name = google_gke_hub_feature.example.name
}
`, context)
}

func testAccCheckGoogleGkeHubFeatureDestroyProducer(t *testing.T) func(s *terraform.State) error {
return func(s *terraform.State) error {
for name, rs := range s.RootModule().Resources {
if rs.Type != "google_gke_hub_feature" {
continue
}
if strings.HasPrefix(name, "data.") {
continue
}

config := acctest.GoogleProviderConfig(t)

url, err := tpgresource.ReplaceVarsForTest(config, rs, "{{GKEHub2BasePath}}projects/{{project}}/locations/{{location}}/features/{{name}}")
if err != nil {
return err
}

billingProject := ""

if config.BillingProject != "" {
billingProject = config.BillingProject
}

_, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
Config: config,
Method: "GET",
Project: billingProject,
RawURL: url,
UserAgent: config.UserAgent,
})
if err == nil {
return fmt.Errorf("GKEHub2Feature still exists at %s", url)
}
}

return nil
}
}

0 comments on commit 6f342c6

Please sign in to comment.