`vertex-ai`: add `google_vertex_ai_models` resource with create-via-copy #12074

BBBmau · 2024-10-21T22:31:51Z

This initial PR will begin with supporting :COPY

replaces #10628

Will include PRs to support :UPLOAD in separate PRs.

:COPY
:UPLOAD vertex-ai: add :UPLOAD support for model resource #12075 - The merging of this PR will introduce renaming of displayName -> modelName. This is meant to make it easier for users to differentiate how to COPY or UPLOAD a model (COPY requires source_model field while UPLOAD requires displayName field but will be renamed to be modelName.
- explanation_spec_examples vertex-ai: add :UPLOAD explanation_spec_examples tests #12170
- explanation_gradients vertex-ai: add :UPLOAD integrated_gradients tests #12171
- explanation_xrai vertex-ai: add :UPLOAD xrai_attributions test #12173
- explanation_shapley vertex-ai: add :UPLOAD sampled_shapley_attributions test #12172

Release Note Template for Downstream PRs (will be copied)

`google_vertex_ai_model`

modular-magician · 2024-11-21T23:57:17Z

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModel_modelIdNotProvidedAtCreateTime [Error message] [Debug log]
TestAccVertexAIModel_modelIdProvidedAtCreateTime [Error message] [Debug log]
TestAccVertexAIModel_postCreationUpdates [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-22T00:50:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2947 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2947 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 776 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_model (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_model" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  encryption_spec {
    kms_key_name = # value needed
  }
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
  }
  metadata_schema_uri = # value needed
  model_name          = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

modular-magician · 2024-11-22T00:55:36Z

Tests analytics

Total tests: 61
Passed tests: 55
Skipped tests: 3
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-22T01:05:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2948 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2948 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 776 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_model (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_model" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  encryption_spec {
    kms_key_name = # value needed
  }
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
  }
  metadata_schema_uri = # value needed
  model_name          = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

modular-magician · 2024-11-22T01:10:35Z

Tests analytics

Total tests: 61
Passed tests: 55
Skipped tests: 3
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-22T01:13:22Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIModel_modelIdNotProvidedAtCreateTime [Debug log]
TestAccVertexAIModel_modelIdProvidedAtCreateTime [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModel_postCreationUpdates [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-22T01:25:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2948 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2948 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 776 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_model (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_model" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  encryption_spec {
    kms_key_name = # value needed
  }
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
  }
  metadata_schema_uri = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

modular-magician · 2024-11-22T01:30:52Z

Tests analytics

Total tests: 61
Passed tests: 57
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-22T01:33:40Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIModel_postCreationUpdates [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

BBBmau · 2024-11-22T09:23:47Z

Just so it doesn't get lost: #12074 (comment)

once this is approved I can merge it into UPLOAD and include UPLOAD as part of the copy tests for initial setup prior to actually testing the copy method by itself.

SarahFrench

Some last comments to get this PR 100% about create via copy and to allow all code changes necessary for upload to be added in the separate upload PR

mmv1/templates/terraform/pre_create/vertex_ai_models.go.tmpl

mmv1/templates/terraform/decoders/vertex_ai_models.go.tmpl

mmv1/templates/terraform/encoders/vertex_ai_models.go.tmpl

Co-authored-by: Sarah French <[email protected]>

modular-magician · 2024-12-04T00:43:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2946 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2946 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 776 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_model (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_model" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  encryption_spec {
    kms_key_name = # value needed
  }
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
  }
  metadata_schema_uri = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

modular-magician · 2024-12-04T00:48:11Z

Tests analytics

Total tests: 61
Passed tests: 58
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-12-04T00:49:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2943 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2943 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 776 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_model (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_model" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  encryption_spec {
    kms_key_name = # value needed
  }
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
  }
  metadata_schema_uri = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

BBBmau · 2024-12-04T00:52:39Z

addressed the last couple changes, should be good for another review and then I could look into upload support. @SarahFrench

modular-magician · 2024-12-04T00:54:07Z

Tests analytics

Total tests: 61
Passed tests: 58
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-12-04T01:01:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2938 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2938 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 771 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_model (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_model" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  encryption_spec {
    kms_key_name = # value needed
  }
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
  }
  metadata_schema_uri = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

modular-magician · 2024-12-04T01:06:53Z

Tests analytics

Total tests: 61
Passed tests: 58
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

SarahFrench

Approving, but just a heads up that this PR is currently due to go into main branch. If you merge it as-is then it'll be in the December 16th release, despite a lack of test coverage etc.

BBBmau · 2024-12-04T18:58:16Z

@SarahFrench changed base to vertex-ai-model-resource in order to include support of UPLOAD, the original idea was to merge this into the existing UPLOAD PR but would just introduce some complex git history. Creating a new branch that would have it's first commit be the support of :COPY is best and just makes the review process easier.

BBBmau mentioned this pull request Oct 21, 2024

Add vertex_ai_model_resource :copy #10628

Closed

BBBmau force-pushed the add-vertex-ai-model-COPY branch from 2900c02 to f964094 Compare October 21, 2024 22:41

This comment was marked as outdated.

Sign in to view

BBBmau mentioned this pull request Oct 21, 2024

vertex-ai: add :UPLOAD support for model resource #12075

Open

5 tasks

This comment was marked as outdated.

Sign in to view

BBBmau force-pushed the add-vertex-ai-model-COPY branch from f964094 to d9a7bde Compare October 21, 2024 22:58

BBBmau requested a review from SarahFrench October 21, 2024 23:09

This comment was marked as duplicate.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as duplicate.

Sign in to view

This comment was marked as outdated.

Sign in to view

source_model id

60a0732

set description field to default_from_api to address diff on apply

55602b0

modelName was set instead of displayName on rebase

f112473

SarahFrench reviewed Nov 22, 2024

View reviewed changes

mmv1/templates/terraform/pre_create/vertex_ai_models.go.tmpl Outdated Show resolved Hide resolved

mmv1/templates/terraform/decoders/vertex_ai_models.go.tmpl Outdated Show resolved Hide resolved

mmv1/templates/terraform/encoders/vertex_ai_models.go.tmpl Outdated Show resolved Hide resolved

BBBmau and others added 2 commits December 3, 2024 16:32

Update mmv1/templates/terraform/decoders/vertex_ai_models.go.tmpl

6983f86

Co-authored-by: Sarah French <[email protected]>

Update mmv1/templates/terraform/pre_create/vertex_ai_models.go.tmpl

65070de

Co-authored-by: Sarah French <[email protected]>

remove modelName from encoder

d27e81d

BBBmau requested a review from SarahFrench December 4, 2024 00:52

SarahFrench approved these changes Dec 4, 2024

View reviewed changes

BBBmau changed the base branch from main to vertex-ai-model-resource December 4, 2024 18:55

BBBmau merged commit 4472d64 into vertex-ai-model-resource Dec 4, 2024
15 of 16 checks passed

BBBmau mentioned this pull request Dec 4, 2024

vertex-ai: add google_vertex_ai_model resource #12490

Draft

6 tasks

vertex-ai: add google_vertex_ai_models resource with create-via-copy #12074

vertex-ai: add google_vertex_ai_models resource with create-via-copy #12074

Conversation

BBBmau commented Oct 21, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as duplicate.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

modular-magician commented Nov 21, 2024

modular-magician commented Nov 22, 2024

Diff report

Missing test report

modular-magician commented Nov 22, 2024

Tests analytics

Action taken

modular-magician commented Nov 22, 2024

Diff report

Missing test report

modular-magician commented Nov 22, 2024

Tests analytics

Action taken

modular-magician commented Nov 22, 2024

modular-magician commented Nov 22, 2024

Diff report

Missing test report

modular-magician commented Nov 22, 2024

Tests analytics

Action taken

modular-magician commented Nov 22, 2024

BBBmau commented Nov 22, 2024

SarahFrench left a comment

Choose a reason for hiding this comment

modular-magician commented Dec 4, 2024

Diff report

Missing test report

modular-magician commented Dec 4, 2024

Tests analytics

modular-magician commented Dec 4, 2024

Diff report

Missing test report

BBBmau commented Dec 4, 2024

modular-magician commented Dec 4, 2024

Tests analytics

modular-magician commented Dec 4, 2024

Diff report

Missing test report

modular-magician commented Dec 4, 2024

Tests analytics

SarahFrench left a comment

Choose a reason for hiding this comment

BBBmau commented Dec 4, 2024 • edited Loading

`vertex-ai`: add `google_vertex_ai_models` resource with create-via-copy #12074

`vertex-ai`: add `google_vertex_ai_models` resource with create-via-copy #12074

BBBmau commented Oct 21, 2024 •

edited

Loading

BBBmau commented Dec 4, 2024 •

edited

Loading