Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertex-ai: add google_vertex_ai_model resource #12490

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Dec 4, 2024

Broken up into separate PRs.

Once each individual checkbox is addressed we can move this out of draft.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_vertex_ai_model`

@BBBmau BBBmau requested a review from SarahFrench December 4, 2024 19:06
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2938 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2938 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 771 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_model (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_model" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  encryption_spec {
    kms_key_name = # value needed
  }
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
  }
  metadata_schema_uri = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 61
Passed tests: 55
Skipped tests: 3
Affected tests: 3

Click here to see the affected service packages
  • vertexai

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModel_modelIdNotProvidedAtCreateTime
  • TestAccVertexAIModel_modelIdProvidedAtCreateTime
  • TestAccVertexAIModel_postCreationUpdates

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVertexAIModel_modelIdNotProvidedAtCreateTime [Debug log]
TestAccVertexAIModel_modelIdProvidedAtCreateTime [Debug log]
TestAccVertexAIModel_postCreationUpdates [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants