-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wrapper for v1.89.4 #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this as long as the upstreams are updated.
847f298
to
5178cef
Compare
I yanked CImGuiPack_jll-v0.1.3 and tagged a new version v0.2.0. |
Overview of changes: - Lots of functions now have an underscore between the C function name and the parameter type, e.g. `igFooStr` -> `igFoo_Str`. - Some functions were completely renamed, which I've marked with `@deprecate`. - Some functions were deleted entirely, like `CalcListClipping()`.
Ported from a C++ example.
Note: this requires a version of ImGuiOpenGLBackend with JuliaImGui/ImGuiOpenGLBackend.jl#4.
590af98
to
b5cd513
Compare
@Gnimuc, I think this is ready to merge now? |
Thanks! |
@JamesWrigley is this ready for a new release? or you're still experimenting with something? |
Nope, this should be ready to go 👍 |
Overview of changes:
igFooStr
->igFoo_Str
.@deprecate
.CalcListClipping()
.I've tested this with the
demo/demo.jl
andexamples/demo.jl
and everything seems to work.Depends on: