Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken after update #100

Closed
heyx3 opened this issue Sep 26, 2023 · 8 comments
Closed

Broken after update #100

heyx3 opened this issue Sep 26, 2023 · 8 comments

Comments

@heyx3
Copy link

heyx3 commented Sep 26, 2023

Hi, it looks like LibCImGui.jl has some updated code that CImGui is not able to deal with? I got the "KeyPadEnter" error already mentioned by somebody else, and after fixing it in my own code I'm getting "igTreeNodeStr(label) not defined" when calling TreeNode(). Because it's been updated to igTreeNode_Str(label).

The package versions I'm using are:

  • CImGui: 1.82.0
  • LibCImGui: 1.89.5
  • CImGuiPack_jll: 0.2.0+0
@wsphillips
Copy link

You need the updates to the GLFW and OpenGL backends to use LibCImGui 1.89. On the tagged release of CImGui 1.82 the compat hasnt been updated. For the moment, try ] add CImGui#master and and running ] up after. You should see the backends update to v0.2.0 and then it should work.

@Gnimuc I think we need to do some compat hygeine and perhaps tag a separate v1.89 release? v1.89 should have minimum bound of v0.2.0 for GLFW and OpenGL backend and v1.82 should be <0.2.0 for both

@heyx3
Copy link
Author

heyx3 commented Sep 26, 2023

I'm not using the built-in backends, I have my own. The error comes from calling a CImGui function within an app, not from within the backend/rendering part.

@heyx3
Copy link
Author

heyx3 commented Sep 29, 2023

In the short-term, what versions of these three packages can I go back to to get the older functional version of the package? I"m a little unclear on the exact relationship between the three packages and which one actually has the breaking changes.

@Gnimuc
Copy link
Owner

Gnimuc commented Sep 29, 2023

I think the broken version has been yanked.

@Gnimuc
Copy link
Owner

Gnimuc commented Sep 29, 2023

cc @JamesWrigley

@heyx3
Copy link
Author

heyx3 commented Sep 29, 2023

Thanks, I fixed it by reverting to CImGui v1.82.0 and LibCimGui v1.82.2

@heyx3 heyx3 closed this as completed Sep 29, 2023
@JamesWrigley
Copy link
Collaborator

Umm, so I think the issue is that CImGui 1.82 and LibCImGui 1.89.5 are incompatible. I'd say we should have a new patch release of CImGui 1.82 with this PR: #90
And then maybe a breaking CImGui 1.89 release with all the 1.89 changes from #87.

This was referenced Nov 10, 2023
@JamesWrigley
Copy link
Collaborator

Things should be working again with v1.82.1 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants