Add options to prefer system libs over some bundled ones #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #81 , issue is well-known. That one didn't get merged due to, I don't know why exactly anymore, sadly. |
|
@Gargaj doesn't this deserve an explanation? |
|
As Poro noted, there's a 18-comment thread over at #81 for this exact same discussion. |
Still not resolved, and this change contains extra code for stb. But OK, I'll move there. |
|
A number of distros don't even package stb, and the Scintilla included here uses a bunch of modifications that renders using the system version not very useful. |
alkama
added a commit
to alkama/Bonzomatic
that referenced
this pull request
Feb 21, 2021
Incorporates changes of @PoroCYon on PR Gargaj#125 (remove useless lexers) Incorporates changes of @linkmauve on PR Gargaj#81 (use system libs) Generalize option for system libs to all external deps and whenever opting for system libs make finding it a requirement with no fallback to vendored like @AMDmi3 suggested on PR Gargaj#147 but use consistent and readable `pkg_search_module` for all libs and `find_path` for header-only deps.
Gargaj
pushed a commit
that referenced
this pull request
Mar 4, 2021
Incorporates changes of @PoroCYon on PR #125 (remove useless lexers) Incorporates changes of @linkmauve on PR #81 (use system libs) Generalize option for system libs to all external deps and whenever opting for system libs make finding it a requirement with no fallback to vendored like @AMDmi3 suggested on PR #147 but use consistent and readable `pkg_search_module` for all libs and `find_path` for header-only deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency bundling is evil - it adds extra work for packages, introduces include/library conflicts, increases build times, prevents bug and security fixes in dependencies from affecting the product. Most package repositories (for instance, debian, fedora) have policies against dependency bundling.
This patch adds options to prefer system libraries over bundled ones for some dependencies (relatively widely packaged ones == these I have in my repository). Scintilla currently does not work as Bonzomatic seem to use internal headers. Merging at least 3 working ones would simplify my life as downstream package maintainer and hopefully help Bonzomatic make its way into more repositories.
Threads dependency was added because of this error which appeared after unbundling one of dependencies:
With this patch, the application successfully builds and runs on FreeBSD.