Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner CMakeLists, better OS separation with use of system libs #148

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

alkama
Copy link
Contributor

@alkama alkama commented Feb 20, 2021

Incorporates changes of @PoroCYon on PR #125 (remove useless lexers)
Incorporates changes of @linkmauve on PR #81 (use system libs)

Incorporates changes of @PoroCYon on PR Gargaj#125 (remove useless lexers)
Incorporates changes of @linkmauve on PR Gargaj#81 (use system libs)

Generalize option for system libs to all external deps and whenever opting for system libs make finding it a requirement with no fallback to vendored like @AMDmi3 suggested on PR Gargaj#147 but use consistent and readable `pkg_search_module` for all libs and `find_path` for header-only deps.
@alkama
Copy link
Contributor Author

alkama commented Feb 21, 2021

Also generalizes option for system libs to all external deps and whenever opting for system libs make finding it a requirement with no fallback to vendored like @AMDmi3 suggested on PR #147 but use consistent and readable pkg_search_module for all libs and find_path for header-only deps.

@Gargaj Gargaj merged commit 51384c9 into Gargaj:master Mar 4, 2021
@alkama alkama deleted the cleaner_make branch March 4, 2021 09:23
@AMDmi3
Copy link
Contributor

AMDmi3 commented Mar 14, 2021

Thanks! This works greate for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants