Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split GSI's mksi into its own repo #289

Closed
rtodling opened this issue Jan 24, 2024 · 8 comments · Fixed by GEOS-ESM/GEOSadas#267, GEOS-ESM/GEOSana_GridComp#157 or #297
Closed

Split GSI's mksi into its own repo #289

rtodling opened this issue Jan 24, 2024 · 8 comments · Fixed by GEOS-ESM/GEOSadas#267, GEOS-ESM/GEOSana_GridComp#157 or #297
Assignees

Comments

@rtodling
Copy link
Contributor

To facilitate the transition to JEDI, it would be good to have mksi sit its own repo - but be placed in the same GSI_GridComp location as it stands when GEOSadas is built.

Added Akira here so she can update swell once the change has been made.

@mathomp4
Copy link
Member

mathomp4 commented Feb 9, 2024

I have two PRs and a new repo in re this. All work in progress though I can say it builds:

@rtodling
Copy link
Contributor Author

Can someone please try working on this in SWELL? Notice that soon I tag this and it will be important that swell pulls a tag and not develop.

@Dooruk
Copy link
Collaborator

Dooruk commented Feb 14, 2024

Can someone please try working on this in SWELL? Notice that soon I tag this and it will be important that swell pulls a tag and not develop.

Sure, I'm not sure what needs to be done. Perhaps @asewnath is more familiar with it?

Is it practically cloning a repo, as is done here?:

https://github.com/GEOS-ESM/swell/blob/develop/src/swell/tasks/clone_geos_ana.py

@rtodling
Copy link
Contributor Author

Doruk: I am trying to remember where I saw this - but somewhere in swell - perhaps when an experiment is created, it pulls the GEOSana_GridComp to tap on mksi which lives in that repo inside the GSI_GridComp. That is, swell is pulling a lot of code just to get to a directory that lives deep inside the GEOSana_GridComp repo.

The idea here is to replace the pulling of GEOSana_GridComp w/ simple GEOS_mksi - which is truly the only part the swell machinery needs.

For example, the HOFX task looks like this (directory after task is created):

configuration
GEOSana_GridComp
jedi_bundle
stage
swell-hofx-suite

If you make the change I am requesting here, the above should like like this:

configuration
GEOS_mksi ------>>>> this will be a much trimmed version of things
jedi_bundle
stage
swell-hofx-suite

@rtodling
Copy link
Contributor Author

BTW: I think this is where the change needs to take place:

swell/tasks/clone_geos_ana.py

this entire script should be renamed to clone_geos_mksi.py and inside, any refs to geosana_gridcomp should change accordingly. I can try to make the change and put it in a PR if you want me to.

@asewnath
Copy link
Contributor

asewnath commented Feb 15, 2024

@rtodling @Dooruk I can make these changes and will tag you in the PR when it's ready (assuming nobody else is working on it yet)

@Dooruk
Copy link
Collaborator

Dooruk commented Feb 15, 2024

@rtodling @Dooruk I can make these changes and will tag you in the PR when it's ready (assuming nobody else is working on it yet)

Thanks @asewnath , no I haven't started working on it.

@rtodling
Copy link
Contributor Author

@rtodling @Dooruk I can make these changes and will tag you in the PR when it's ready (assuming nobody else is working on it yet)

Thanks Akira - that would be nice. Pls tag me in the PR so I can learn ... thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants