Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning GEOS_mksi instead for GSI channel records #297

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Cloning GEOS_mksi instead for GSI channel records #297

merged 4 commits into from
Feb 16, 2024

Conversation

asewnath
Copy link
Contributor

Description

Thanks to @mathomp4, we have a lightweight repository for accessing GSI channel records.

Changes include:

  • Renaming task references to CloneGeosMksi and task script is called clone_geos_mksi.py
  • Modifying clone_geos_mksi.py to clone GEOS_mksi instead and updating all paths as necessary
  • Adding ability to use a tag for GEOS_mksi (question shows up in experiment.yaml)

Closes #289

@Dooruk
Copy link
Collaborator

Dooruk commented Feb 15, 2024 •
edited
Loading

Thanks @asewnath for making this change swiftly and tnaks @mathomp4 for the GEOS-ESM repo.s==s.

Just a question for @rtodling. Does the following setup work as default, which uses the geosadas suite? That would be only way for me to test this PR or CI-workflow to test it.
https://github.com/GEOS-ESM/swell/blob/develop/src/swell/test/suite_tests/geosadas-tier1.yaml

rtodling
rtodling reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the minor comments I make below - this is looking good!

src/swell/configuration/jedi/interfaces/geos_atmosphere/task_questions.yaml Outdated Show resolved Hide resolved
src/swell/tasks/clone_geos_mksi.py Outdated Show resolved Hide resolved
src/swell/tasks/generate_observing_system_records.py Outdated Show resolved Hide resolved
src/swell/tasks/task_questions.yaml Outdated Show resolved Hide resolved
@asewnath
Copy link
Contributor Author

Thanks @asewnath for making this change swiftly and tnaks @mathomp4 for the GEOS-ESM repo.s==s.

Just a question for @rtodling. Does the following setup work as default, which uses the geosadas suite? That would be only way for me to test this PR or CI-workflow to test it. https://github.com/GEOS-ESM/swell/blob/develop/src/swell/test/suite_tests/geosadas-tier1.yaml

If it helps, I tested the changes locally using the ufo_testing suite

Dooruk
Dooruk approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier1 tests work, so if @rtodling approves it's good to merge! Thank you @asewnath for the quick turnaround.

@Dooruk Dooruk mentioned this pull request Feb 16, 2024
Merged
@Dooruk Dooruk merged commit ec31d25 into develop Feb 16, 2024
9 checks passed
@Dooruk Dooruk deleted the feature/clone_geos_mksi branch February 16, 2024 18:51
@rtodling
Copy link
Contributor

Thank you!

danholdaway added a commit to danholdaway/swell that referenced this pull request Apr 19, 2024
@danholdaway
Merge branch 'develop' into feature/refactor_prep_config
a566007 
* develop:
  Resolve pandas warnings (GEOS-ESM#322)
  Add atmospheric 3DVar case (GEOS-ESM#302)
  Update to Skylab7 Modules - Part 1 (SLES12) (GEOS-ESM#319)
  Towards ensemble hofx support (GEOS-ESM#298)
  Change Jedi Log plot and turn off Jb evaluation (GEOS-ESM#310)
  passed benchmark change (GEOS-ESM#303)
  Use `EXPLICIT_DIFFUSION` as Static Background for `geos_marine` (GEOS-ESM#301)
  Fix to check for missing obs in SaveObsDiag (GEOS-ESM#299)
  Cloning GEOS_mksi instead for GSI channel records (GEOS-ESM#297)
  Update modules and keep static files in shared locations (GEOS-ESM#296)
  Addressing missing observations (GEOS-ESM#286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dooruk Dooruk Dooruk approved these changes

@rtodling rtodling Awaiting requested review from rtodling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split GSI's mksi into its own repo
3 participants
@asewnath @Dooruk @rtodling