Extract mksi into new repo #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff structural
This was referenced Feb 9, 2024
rtodling
approved these changes
Mar 18, 2024
rtodling
previously approved these changes
Sep 24, 2024
|
@mathomp4 Have Matt, can we just get this in? |
Oh sure. Let me fix the conflicts and then you can merge. |
# Conflicts: # GEOSaana_GridComp/GSI_GridComp/mksi/sidb/active_channels.tbl # GEOSaana_GridComp/GSI_GridComp/mksi/sidb/available_channels.tbl # GEOSaana_GridComp/GSI_GridComp/mksi/sidb/iuseClass-4_channels.tbl
pchakraborty
approved these changes
Sep 24, 2024
|
@rtodling I fixed up the conflicts and it should be good to go. You can re-approve and merge as you wish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR along with GEOS-ESM/GEOSadas#267 is an attempt to extract the
mksifolder in GEOSana_GridComp into its own repo. To do so, the RepoExtractor tool was run as:and a new repo GEOS_mksi was created:
https://github.com/GEOS-ESM/GEOS_mksi
Then GEOS_mksi was added as a new component and placed as
@mksi/underGSI_GridComp/Tests show it builds which should be proof it is correct, but probably needs testing to be sure.
And of course, before anything is done, tags should be made in GEOS_mksi and GEOSana_GridComp.
Closes GEOS-ESM/swell#289