Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build MAPL3 as SHARED only #2825

Merged
merged 1 commit into from
May 13, 2024
Merged

Build MAPL3 as SHARED only #2825

merged 1 commit into from
May 13, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented May 13, 2024 •
edited
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Due to how MAPL3 works, we can no longer mix STATIC and SHARED libraries in MAPL. This PR removes the BUILD_SHARED_MAPL CMake option and makes all libraries SHARED.

Related Issue

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label May 13, 2024
@mathomp4 mathomp4 self-assigned this May 13, 2024
@mathomp4 mathomp4 marked this pull request as ready for review May 13, 2024 14:58
@mathomp4 mathomp4 requested review from a team as code owners May 13, 2024 14:58
@tclune tclune merged commit 0d39718 into release/MAPL-v3 May 13, 2024
44 checks passed
@tclune tclune deleted the feature/mathomp4/remove-static-build-mapl3 branch May 13, 2024 19:14
@mathomp4 mathomp4 mentioned this pull request Jun 21, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune