Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake in GeomIO #2882

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

mathomp4
Copy link
Member

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Closes #2881

Testing with ifx as shown in #2881 found a bug in MAPL 3. Namely, we had a stray MAPL_LIBRARY_TYPE in GeomIO. I (thought that I) removed all of those in #2825 , but nope.

Amazingly, MAPL 3 hasn't gone belly up. But this is a bug.

Related Issue

@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Jun 21, 2024
@mathomp4 mathomp4 self-assigned this Jun 21, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner June 21, 2024 18:36
@mathomp4 mathomp4 merged commit 27d47d4 into release/MAPL-v3 Jun 24, 2024
48 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/fix-geomio-cmake branch June 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants