Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New folders in geom_mgr to accommodate submodule files. #2817

Merged
merged 4 commits into from
May 9, 2024
Merged

New folders in geom_mgr to accommodate submodule files. #2817

merged 4 commits into from
May 9, 2024

Conversation

JulesKouatchou
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

We broke the files CoordinateAxis_smod.F90, GeomManager_smod.F90, MaplGeom_smod.F90 and VectorBasis_smod.F90 into individual submodule files (each file corresponding to a submodule with one procedure only). The newly created files were placed in the folders: CoordinateAxis, GeomManager, MaplGeom and VectorBasis.

Related Issue

@JulesKouatchou JulesKouatchou requested review from a team as code owners May 8, 2024 19:05
tclune
tclune reviewed May 8, 2024
View reviewed changes
geom_mgr/CMakeLists.txt Outdated Show resolved Hide resolved
@tclune tclune self-requested a review May 8, 2024 19:56
@JulesKouatchou JulesKouatchou mentioned this pull request May 9, 2024
Closed
6 tasks
@JulesKouatchou
Copy link
Contributor Author

  • 0-diff
  • changelog-skip (because it is a MAPL3 PR)

@JulesKouatchou JulesKouatchou added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels May 9, 2024
@tclune tclune merged commit 88c08ca into release/MAPL-v3 May 9, 2024
35 checks passed
@tclune tclune deleted the feature/jk/add/submodules branch May 9, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulesKouatchou @tclune