Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created folders in geom_mgr to include submodule files #2816

Closed
wants to merge 1,647 commits into from

Conversation

JulesKouatchou
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

We created the folders CoordinateAxis, GeomManager, MaplGeom and VectorBasis that now host submodule files (each file contains a submodule for one procedure only). The submodules are needed in the modules in CoordinateAxis.F90, GeomManager.F90, MaplGeom.F90 and VectorBasis.F90.

Related Issue

mathomp4 and others added 30 commits April 4, 2024 07:27
Reduced complexity of logic for computing ungridedd bounds for ESMF
creation step and placed into separate functions.
Also VerticalGrid partially captured.  Has the
dimspec (none/center/edge), but not num_levels.
bena-nasa and others added 24 commits April 30, 2024 13:18
…tory3g_collection_imports

Extract multiple field names from var_list expressions in History3g Collection
The generic phases are now offset beyond any reasonable user phase.
This avoids the need to add/subtract offsets for user phases.

Also added hook that allows user to customize generic clock advance.
@JulesKouatchou JulesKouatchou requested review from a team as code owners May 8, 2024 18:29
Copy link

github-actions bot commented May 8, 2024

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, 😲 Non 0 Diff, 🔧 Github Actions. Please add one so that the PR can be merged.

@JulesKouatchou
Copy link
Contributor Author

Close this one to select only select PR #2817.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants