Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit action workflow #928

Merged
merged 2 commits into from
May 20, 2024
Merged

Add pre-commit action workflow #928

merged 2 commits into from
May 20, 2024

Conversation

fredrikekre
Copy link
Member

This patch adds a GitHub Action workflow to run
pre-commit to run checks on changed files.

The following checks are active:

  • check-added-large-files: prevent large files from being committed
  • check-case-conflict: checks for files that would conflict in case-insensitive filesystems
  • check-toml, check-yaml: check toml/yaml parseability
  • end-of-file-fixer: make sure files end with newline
  • mixed-line-ending: check for mixed line endings
  • trailing-whitespace: no trailing whitespace

To configure pre-commit to run locally when committing: i) install pre-commit and ii) install the hook with pre-commit install.

This patch adds a GitHub Action workflow to run
[pre-commit](https://pre-commit.com/) to run checks on changed files.

The following checks are active:
 - check-added-large-files: prevent large files from being committed
 - check-case-conflict: checks for files that would conflict in
   case-insensitive filesystems
 - check-toml, check-yaml: check toml/yaml parseability
 - end-of-file-fixer: make sure files end with newline
 - mixed-line-ending: check for mixed line endings
 - trailing-whitespace: no trailing whitespace

To configure `pre-commit` to run locally when committing: i) install
pre-commit and ii) install the hook with `pre-commit install`.
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.86%. Comparing base (15db94b) to head (eb8f267).

Files Patch % Lines
src/interpolations.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files          36       36           
  Lines        5310     5310           
=======================================
  Hits         4984     4984           
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit should be added to .git-blame-ignore-revs.
@fredrikekre fredrikekre merged commit 68e1ab1 into master May 20, 2024
11 of 12 checks passed
@fredrikekre fredrikekre deleted the fe/pre-commit branch May 20, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant