-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix type error in grid generators and add some test functions for gri… #973
fix type error in grid generators and add some test functions for gri… #973
Conversation
Thanks for putting this together @Abdelrahman912 ! I left a few minor comments. It should be good to go afterwards. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 36 36
Lines 5438 5440 +2
=======================================
+ Hits 5095 5097 +2
Misses 343 343 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉
Just two small drive-by comments from me
- I think it is more logical to take the type parameter from the node than the left point (even if this is equivalent, but seeing that requires looking at the call site)
- I think it is better to convert and then do division by integer. For
Float32
it doesn't matter (only perf), but for higher precision floats it makes a difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just left some comments on the testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on your first PR @Abdelrahman912 🚀
Content-wise this looks good to me now, just some formatting fixes as commented below, and the pre-commit action should pass. See #928 for detail on how to do that automatically.
Summary
This PR fixes type conversion issues in the
generate_grid
function ingrid_generators.jl
and adds test coverage for all grid generators.Tests
test/test_grid_generators.jl
.