Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rosdep install execution #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

marcoshuck
Copy link
Member

Proposed changes

Running rosdep update and rosdep install returns a permission denied error as described in #114. This prevented the release target to be executed.

Adding a rosdep fix-permissions instruction to be run in sudo mode fixes the issue.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Additional comments

Fix #114

Running rosdep update and rosdep install returns a permission denied error as described in #114. This prevented the release target to be executed.

Adding a `rosdep fix-permissions` instruction to be run in sudo mode fixes the issue.

Signed-off-by: Marcos Huck <[email protected]>
@@ -53,6 +53,9 @@ build:
WORKDIR /workspace
RUN cd src && git clone https://github.com/Ekumen-OS/beluga
COPY . src/beluga_vs_nav2
USER root
RUN rosdep fix-permissions
USER ${USER}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoshuck good catch! IIUC there are two different issues here:

  1. the build target (or stage) is running with a user other than root
  2. running rosdep with root breaks it for the non-root user

We can fix 1. by using lambkin+embed-ubuntu-devel as base image of the build target (up in line 51) instead of the lambkin+ubuntu-devel image. That will unblock you just the same. We could perhaps double check we are not basing build targets from anything other embed-* targets elsewhere too.

Fixing 2. is tiny bit more involved. rosdep fix-permissions has to be invoked with sudo after os+ADDUSER is invoked for development targets. Perhaps an idempotent ros+FIXUSER right after os+ADDUSER is not that bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build beluga vs nav2 benchmark image for release target
2 participants