Fix issue 181

[SarahAlidoost]

Description

closes #181, the merge is pending addressing issues mentioned here. This branch re-produces the same results as those generated by the main branch, tested with a small dataset.

Checklist

• Add a reference to related issues.
• @mentions of the person or team responsible for reviewing proposed changes.
• This pull request has a descriptive title.
• Code is written according to the guidelines.
• The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
• Documentation is available.
• Add changes to the changelog file under section Unreleased.
• Model runs successfully.
• Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

[BSchilperoort]

Looks good, nice work! I checked the model results and there seems to be no change at all between main and this branch.

It would be nice to have docstrings in many of the new functions though (what does the function do? what are the inputs? what's the source of the equations?). But I know you can't write those. Perhaps keeping track of the functions that still need a docstring in an issue could be a good idea?

[SarahAlidoost]

Looks good, nice work! I checked the model results and there seems to be no change at all between main and this branch.

It would be nice to have docstrings in many of the new functions though (what does the function do? what are the inputs? what's the source of the equations?). But I know you can't write those. Perhaps keeping track of the functions that still need a docstring in an issue could be a good idea?

thanks a lot for reviewing and running the code. I agree that the code needs more documentation, I submitted issue #191 for this.

[SarahAlidoost]

❗ 🔴 Waiting for addressing issues mentioned here before the merge.