Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain subRoutine in functions calculateDTheta and calculateTheta #192

Open
SarahAlidoost opened this issue Aug 7, 2023 · 0 comments
Open

Explain subRoutine in functions calculateDTheta and calculateTheta #192

SarahAlidoost opened this issue Aug 7, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@SarahAlidoost
Copy link
Member

Pull request #189 creates two new functions calculateDTheta and calculateTheta that are used to calculate Theta_* and DTheta_* variables. To re-use code, a switch case block is implemented in each function using the variable subRoutine. It would be nicer if this subRoutine was more explained (what subroutine is for what), and possibly used strings instead of integers to describe the cases.
@SarahAlidoost SarahAlidoost added the documentation Improvements or additions to documentation label Aug 7, 2023
@SarahAlidoost SarahAlidoost mentioned this issue Aug 7, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SarahAlidoost