-
-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add german contributing guidelines #5720
Add german contributing guidelines #5720
Conversation
…ibution files, re-order list alphabetically.
|
||
4. Stell sicher, dass du den [Richtlinien](#richtlinien) folgst und die [Markdown Formatierung](#formatierung) der Dateien beachtest. | ||
|
||
5. GitHub Actions werden Tests ausführen, um sicherzustellen, dass die Listen korrekt alphabetisiert sind and den Formatierungsregeln Folge geleistet wurde. Stell sicher, dass deine Änderungen diese Tests bestehen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It satisfy #5644 🎉
|
||
### Automatisierung | ||
|
||
- Die Durchsetzung der Formatierungsregeln wird über [GitHub Actions](https://github.com/features/actions) mittels [fpb-lint](https://github.com/vhf/free-programming-books-lint) sichergestellt (siehe [.github/workflows/fpb-lint.yml](.github/workflows/fpb-lint.yml)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It satisfy #5644 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of appending the link to the end of the list, I re-ordered the first part of the list alphabetically. Let me know if there's a reason why it wasn't alphabetical before, and I will change it accordingly.
I am for the work of sticking to what is strictly necessary. It's simple: avoid anoying merge conflicts due to have so many PRs touching the first paragraph. We can always deal with it when all of them will be commited. #5762
❓ Could you swap back French and Spanish?
Sure, will do. Where should the German link go then - at the end, or is there any other concept? |
…tribution Guidelines.
I swapped back French and Spanish. If you want me to put German at the end or anywhere else, please let me know. 👍 |
At the moment as it is. To handle at #5762 |
Nice 👍 You sure have an issue for just about everything 😲 |
CONTRIBUTING-fa_IR.md
Outdated
@@ -1,4 +1,4 @@ | |||
*این متن را در زبانهای دیگر بخوانید: [English](CONTRIBUTING.md), [Français](CONTRIBUTING-fr.md), [Español](CONTRIBUTING-es.md), [简体中文](CONTRIBUTING-zh.md), [繁體中文](CONTRIBUTING-zh_TW.md), [Tiếng Việt](CONTRIBUTING-vn.md), [Русский](CONTRIBUTING-ru.md).* | |||
*این متن را در زبانهای دیگر بخوانید: [Deutsch](CONTRIBUTING-de.md), [English](CONTRIBUTING.md) , [Français](CONTRIBUTING-fr.md), [Español](CONTRIBUTING-es.md), [简体中文](CONTRIBUTING-zh.md), [繁體中文](CONTRIBUTING-zh_TW.md), [Tiếng Việt](CONTRIBUTING-vn.md), [Русский](CONTRIBUTING-ru.md).* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some extra space after English and it comma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, it slipped my attention... RTL can be a little awkward to edit 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. And mixing glyph types is a bit weird due to, at least for me, don't know where put the cursor 😥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your valuable effort 🙄
Ready to merge 🎆 🎉
I agree that there should be some order to the language lists, but now is a bad time to do it because of conflicts. Could you add an issue about that so it gets taken care of? |
Yes, agreed. An issue already exists at #5762 as @davorpa pointed out earlier. Glad to contribute. Thanks for your work on the repo! |
What does this PR do?
Add a German version of the contribution guidelines.
For resources
Description
Complementing the work on #5684, I added a translation for the contribution guidelines in German and added links to all other contribution files'
Read this in other languages
lines.Instead of appending the link to the end of the list, I re-ordered the first part of the list alphabetically. Let me know if there's a reason why it wasn't alphabetical before, and I will change it accordingly.
Why is this valuable (or not)?
It improves accessibility for the community beyond native english speakers.
Checklist:
Follow-up